Samir Boulahtit
39dff4ab7d
Major changes: - Add AuditProvider protocol for cross-module audit logging - Move customer order operations to orders module (dependency inversion) - Add customer order metrics via MetricsProvider pattern - Fix missing db parameter in get_admin_context() calls - Move ProductMedia relationship to catalog module (proper ownership) - Add marketplace breakdown stats to marketplace_widgets New files: - contracts/audit.py - AuditProviderProtocol - core/services/audit_aggregator.py - Aggregates audit providers - monitoring/services/audit_provider.py - Monitoring audit implementation - orders/services/customer_order_service.py - Customer order operations - orders/routes/api/vendor_customer_orders.py - Customer order endpoints - catalog/services/product_media_service.py - Product media service - Architecture documentation for patterns Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
90 lines
2.6 KiB
Python
90 lines
2.6 KiB
Python
# app/modules/contracts/__init__.py
|
|
"""
|
|
Cross-module contracts using Protocol pattern.
|
|
|
|
This module defines type-safe interfaces for cross-module communication.
|
|
Modules depend on protocols rather than concrete implementations, enabling:
|
|
- Loose coupling between modules
|
|
- Testability through mock implementations
|
|
- Clear dependency boundaries
|
|
|
|
Usage:
|
|
from app.modules.contracts.cms import ContentServiceProtocol
|
|
|
|
class OrderService:
|
|
def __init__(self, content: ContentServiceProtocol | None = None):
|
|
self._content = content
|
|
|
|
@property
|
|
def content(self) -> ContentServiceProtocol:
|
|
if self._content is None:
|
|
from app.modules.cms.services import content_page_service
|
|
self._content = content_page_service
|
|
return self._content
|
|
|
|
Metrics Provider Pattern:
|
|
from app.modules.contracts.metrics import MetricsProviderProtocol, MetricValue
|
|
|
|
class OrderMetricsProvider:
|
|
@property
|
|
def metrics_category(self) -> str:
|
|
return "orders"
|
|
|
|
def get_vendor_metrics(self, db, vendor_id, context=None) -> list[MetricValue]:
|
|
return [MetricValue(key="orders.total", value=42, label="Total", category="orders")]
|
|
|
|
Widget Provider Pattern:
|
|
from app.modules.contracts.widgets import DashboardWidgetProviderProtocol, DashboardWidget
|
|
|
|
class OrderWidgetProvider:
|
|
@property
|
|
def widgets_category(self) -> str:
|
|
return "orders"
|
|
|
|
def get_vendor_widgets(self, db, vendor_id, context=None) -> list[DashboardWidget]:
|
|
return [DashboardWidget(key="orders.recent", widget_type="list", ...)]
|
|
"""
|
|
|
|
from app.modules.contracts.audit import (
|
|
AuditEvent,
|
|
AuditProviderProtocol,
|
|
)
|
|
from app.modules.contracts.base import ServiceProtocol
|
|
from app.modules.contracts.cms import ContentServiceProtocol
|
|
from app.modules.contracts.metrics import (
|
|
MetricValue,
|
|
MetricsContext,
|
|
MetricsProviderProtocol,
|
|
)
|
|
from app.modules.contracts.widgets import (
|
|
BreakdownWidget,
|
|
DashboardWidget,
|
|
DashboardWidgetProviderProtocol,
|
|
ListWidget,
|
|
WidgetBreakdownItem,
|
|
WidgetContext,
|
|
WidgetListItem,
|
|
)
|
|
|
|
__all__ = [
|
|
# Base protocols
|
|
"ServiceProtocol",
|
|
# CMS protocols
|
|
"ContentServiceProtocol",
|
|
# Audit protocols
|
|
"AuditEvent",
|
|
"AuditProviderProtocol",
|
|
# Metrics protocols
|
|
"MetricValue",
|
|
"MetricsContext",
|
|
"MetricsProviderProtocol",
|
|
# Widget protocols
|
|
"WidgetContext",
|
|
"WidgetListItem",
|
|
"WidgetBreakdownItem",
|
|
"ListWidget",
|
|
"BreakdownWidget",
|
|
"DashboardWidget",
|
|
"DashboardWidgetProviderProtocol",
|
|
]
|