Samir Boulahtit
d7a0ff8818
This commit completes the migration to a fully module-driven architecture: ## Models Migration - Moved all domain models from models/database/ to their respective modules: - tenancy: User, Admin, Vendor, Company, Platform, VendorDomain, etc. - cms: MediaFile, VendorTheme - messaging: Email, VendorEmailSettings, VendorEmailTemplate - core: AdminMenuConfig - models/database/ now only contains Base and TimestampMixin (infrastructure) ## Schemas Migration - Moved all domain schemas from models/schema/ to their respective modules: - tenancy: company, vendor, admin, team, vendor_domain - cms: media, image, vendor_theme - messaging: email - models/schema/ now only contains base.py and auth.py (infrastructure) ## Routes Migration - Moved admin routes from app/api/v1/admin/ to modules: - menu_config.py -> core module - modules.py -> tenancy module - module_config.py -> tenancy module - app/api/v1/admin/ now only aggregates auto-discovered module routes ## Menu System - Implemented module-driven menu system with MenuDiscoveryService - Extended FrontendType enum: PLATFORM, ADMIN, VENDOR, STOREFRONT - Added MenuItemDefinition and MenuSectionDefinition dataclasses - Each module now defines its own menu items in definition.py - MenuService integrates with MenuDiscoveryService for template rendering ## Documentation - Updated docs/architecture/models-structure.md - Updated docs/architecture/menu-management.md - Updated architecture validation rules for new exceptions ## Architecture Validation - Updated MOD-019 rule to allow base.py in models/schema/ - Created core module exceptions.py and schemas/ directory - All validation errors resolved (only warnings remain) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
272 lines
9.7 KiB
Python
272 lines
9.7 KiB
Python
# tests/unit/models/database/test_admin_platform.py
|
|
"""
|
|
Unit tests for AdminPlatform model.
|
|
|
|
Tests the admin-platform junction table model and its relationships.
|
|
"""
|
|
|
|
import pytest
|
|
from sqlalchemy.exc import IntegrityError
|
|
|
|
from app.modules.tenancy.models import AdminPlatform
|
|
|
|
|
|
@pytest.mark.unit
|
|
@pytest.mark.database
|
|
@pytest.mark.admin
|
|
class TestAdminPlatformModel:
|
|
"""Test AdminPlatform model creation and constraints."""
|
|
|
|
def test_create_admin_platform_assignment(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test creating an admin platform assignment."""
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(assignment)
|
|
|
|
assert assignment.id is not None
|
|
assert assignment.user_id == test_platform_admin.id
|
|
assert assignment.platform_id == test_platform.id
|
|
assert assignment.is_active is True
|
|
assert assignment.assigned_by_user_id == test_super_admin.id
|
|
assert assignment.assigned_at is not None
|
|
|
|
def test_admin_platform_unique_constraint(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test that an admin can only be assigned to a platform once."""
|
|
# Create first assignment
|
|
assignment1 = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment1)
|
|
db.commit()
|
|
|
|
# Try to create duplicate assignment
|
|
assignment2 = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment2)
|
|
|
|
with pytest.raises(IntegrityError):
|
|
db.commit()
|
|
|
|
def test_admin_platform_cascade_delete_user(
|
|
self, db, auth_manager, test_platform, test_super_admin
|
|
):
|
|
"""Test that deleting user cascades to admin platform assignments."""
|
|
from app.modules.tenancy.models import User
|
|
|
|
# Create a temporary admin
|
|
temp_admin = User(
|
|
email="temp_admin@example.com",
|
|
username="temp_admin",
|
|
hashed_password=auth_manager.hash_password("temppass"),
|
|
role="admin",
|
|
is_active=True,
|
|
is_super_admin=False,
|
|
)
|
|
db.add(temp_admin)
|
|
db.flush()
|
|
|
|
# Create assignment
|
|
assignment = AdminPlatform(
|
|
user_id=temp_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
|
|
assignment_id = assignment.id
|
|
|
|
# Delete user - should cascade to assignment
|
|
db.delete(temp_admin)
|
|
db.commit()
|
|
|
|
# Verify assignment is gone
|
|
remaining = db.query(AdminPlatform).filter(AdminPlatform.id == assignment_id).first()
|
|
assert remaining is None
|
|
|
|
def test_admin_platform_relationships(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test AdminPlatform relationships are loaded correctly."""
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(assignment)
|
|
|
|
# Test relationships
|
|
assert assignment.user is not None
|
|
assert assignment.user.id == test_platform_admin.id
|
|
assert assignment.platform is not None
|
|
assert assignment.platform.id == test_platform.id
|
|
assert assignment.assigned_by is not None
|
|
assert assignment.assigned_by.id == test_super_admin.id
|
|
|
|
def test_admin_platform_properties(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test AdminPlatform computed properties."""
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(assignment)
|
|
|
|
# Test properties
|
|
assert assignment.platform_code == test_platform.code
|
|
assert assignment.platform_name == test_platform.name
|
|
|
|
def test_admin_platform_repr(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test AdminPlatform string representation."""
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(assignment)
|
|
|
|
repr_str = repr(assignment)
|
|
assert "AdminPlatform" in repr_str
|
|
assert str(test_platform_admin.id) in repr_str
|
|
assert str(test_platform.id) in repr_str
|
|
|
|
|
|
@pytest.mark.unit
|
|
@pytest.mark.database
|
|
@pytest.mark.admin
|
|
class TestUserAdminMethods:
|
|
"""Test User model admin-related methods."""
|
|
|
|
def test_is_super_admin_user_true(self, db, test_super_admin):
|
|
"""Test is_super_admin_user property for super admin."""
|
|
assert test_super_admin.is_super_admin_user is True
|
|
|
|
def test_is_super_admin_user_false_for_platform_admin(self, db, test_platform_admin):
|
|
"""Test is_super_admin_user property for platform admin."""
|
|
assert test_platform_admin.is_super_admin_user is False
|
|
|
|
def test_is_platform_admin_true(self, db, test_platform_admin):
|
|
"""Test is_platform_admin property for platform admin."""
|
|
assert test_platform_admin.is_platform_admin is True
|
|
|
|
def test_is_platform_admin_false_for_super_admin(self, db, test_super_admin):
|
|
"""Test is_platform_admin property for super admin."""
|
|
assert test_super_admin.is_platform_admin is False
|
|
|
|
def test_can_access_platform_super_admin(self, db, test_super_admin, test_platform):
|
|
"""Test that super admin can access any platform."""
|
|
assert test_super_admin.can_access_platform(test_platform.id) is True
|
|
|
|
def test_can_access_platform_assigned(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test that platform admin can access assigned platform."""
|
|
# Create assignment
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(test_platform_admin)
|
|
|
|
assert test_platform_admin.can_access_platform(test_platform.id) is True
|
|
|
|
def test_can_access_platform_not_assigned(
|
|
self, db, test_platform_admin, test_platform
|
|
):
|
|
"""Test that platform admin cannot access unassigned platform."""
|
|
# No assignment created
|
|
assert test_platform_admin.can_access_platform(test_platform.id) is False
|
|
|
|
def test_can_access_platform_inactive_assignment(
|
|
self, db, test_platform_admin, test_platform, test_super_admin
|
|
):
|
|
"""Test that platform admin cannot access platform with inactive assignment."""
|
|
# Create inactive assignment
|
|
assignment = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=False, # Inactive
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add(assignment)
|
|
db.commit()
|
|
db.refresh(test_platform_admin)
|
|
|
|
assert test_platform_admin.can_access_platform(test_platform.id) is False
|
|
|
|
def test_get_accessible_platform_ids_super_admin(self, db, test_super_admin):
|
|
"""Test get_accessible_platform_ids returns None for super admin."""
|
|
result = test_super_admin.get_accessible_platform_ids()
|
|
assert result is None # None means all platforms
|
|
|
|
def test_get_accessible_platform_ids_platform_admin(
|
|
self, db, test_platform_admin, test_platform, another_platform, test_super_admin
|
|
):
|
|
"""Test get_accessible_platform_ids returns correct list for platform admin."""
|
|
# Create assignments for both platforms
|
|
assignment1 = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=test_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
assignment2 = AdminPlatform(
|
|
user_id=test_platform_admin.id,
|
|
platform_id=another_platform.id,
|
|
is_active=True,
|
|
assigned_by_user_id=test_super_admin.id,
|
|
)
|
|
db.add_all([assignment1, assignment2])
|
|
db.commit()
|
|
db.refresh(test_platform_admin)
|
|
|
|
result = test_platform_admin.get_accessible_platform_ids()
|
|
assert len(result) == 2
|
|
assert test_platform.id in result
|
|
assert another_platform.id in result
|
|
|
|
def test_get_accessible_platform_ids_no_assignments(self, db, test_platform_admin):
|
|
"""Test get_accessible_platform_ids returns empty list when no assignments."""
|
|
result = test_platform_admin.get_accessible_platform_ids()
|
|
assert result == []
|
|
|
|
def test_get_accessible_platform_ids_vendor_user(self, db, test_vendor_user):
|
|
"""Test get_accessible_platform_ids returns empty list for non-admin."""
|
|
result = test_vendor_user.get_accessible_platform_ids()
|
|
assert result == []
|