Files
orion/app/modules/orders/definition.py
Samir Boulahtit 03395a9dfa refactor: implement module-driven permissions and relocate business logic
File Relocations:
- Delete app/config/ folder (empty after menu_registry removal)
- Move feature_gate.py → app/modules/billing/dependencies/
- Move theme_presets.py → app/modules/cms/services/

Module-Driven Permissions System:
- Add PermissionDefinition dataclass to app/modules/base.py
- Create PermissionDiscoveryService in tenancy module
- Update module definitions to declare their own permissions:
  - core: dashboard.view, settings.*
  - catalog: products.*
  - orders: orders.*
  - inventory: stock.*
  - customers: customers.*
  - tenancy: team.*
- Update app/core/permissions.py to use discovery service
- Role presets (owner, manager, staff, etc.) now use module permissions

This follows the same pattern as module-driven menus:
- Each module defines its permissions in definition.py
- PermissionDiscoveryService aggregates all permissions at runtime
- Tenancy module handles role-to-permission assignment

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:42:13 +01:00

152 lines
4.9 KiB
Python

# app/modules/orders/definition.py
"""
Orders module definition.
Defines the orders module including its features, menu items,
route configurations, and self-contained module settings.
"""
from app.modules.base import (
MenuItemDefinition,
MenuSectionDefinition,
ModuleDefinition,
PermissionDefinition,
)
from app.modules.enums import FrontendType
def _get_admin_router():
"""Lazy import of admin router to avoid circular imports."""
from app.modules.orders.routes.admin import admin_router
return admin_router
def _get_vendor_router():
"""Lazy import of vendor router to avoid circular imports."""
from app.modules.orders.routes.vendor import vendor_router
return vendor_router
# Orders module definition
orders_module = ModuleDefinition(
code="orders",
name="Order Management",
description=(
"Order processing, fulfillment tracking, customer checkout, "
"invoicing, and bulk order operations. Uses the payments module for checkout."
),
version="1.0.0",
requires=["payments"], # Depends on payments module for checkout
# Module-driven permissions
permissions=[
PermissionDefinition(
id="orders.view",
label_key="orders.permissions.orders_view",
description_key="orders.permissions.orders_view_desc",
category="orders",
),
PermissionDefinition(
id="orders.edit",
label_key="orders.permissions.orders_edit",
description_key="orders.permissions.orders_edit_desc",
category="orders",
),
PermissionDefinition(
id="orders.cancel",
label_key="orders.permissions.orders_cancel",
description_key="orders.permissions.orders_cancel_desc",
category="orders",
),
PermissionDefinition(
id="orders.refund",
label_key="orders.permissions.orders_refund",
description_key="orders.permissions.orders_refund_desc",
category="orders",
),
],
features=[
"order_management", # Basic order CRUD
"order_bulk_actions", # Bulk status updates
"order_export", # Export orders to CSV/Excel
"automation_rules", # Order automation rules
"fulfillment_tracking", # Shipping and tracking
"shipping_management", # Carrier integration
"order_exceptions", # Order item exception handling
"customer_checkout", # Customer checkout flow
"invoice_generation", # Invoice creation
"invoice_pdf", # PDF invoice generation
],
menu_items={
FrontendType.ADMIN: [
"orders", # Platform-wide order management
],
FrontendType.VENDOR: [
"orders", # Vendor order management
],
},
# New module-driven menu definitions
menus={
FrontendType.ADMIN: [
MenuSectionDefinition(
id="vendorOps",
label_key="orders.menu.vendor_operations",
icon="clipboard-list",
order=40,
items=[
MenuItemDefinition(
id="orders",
label_key="orders.menu.orders",
icon="clipboard-list",
route="/admin/orders",
order=40,
),
],
),
],
FrontendType.VENDOR: [
MenuSectionDefinition(
id="sales",
label_key="orders.menu.sales_orders",
icon="document-text",
order=20,
items=[
MenuItemDefinition(
id="orders",
label_key="orders.menu.orders",
icon="document-text",
route="/vendor/{vendor_code}/orders",
order=10,
is_mandatory=True,
),
],
),
],
},
is_core=False,
# =========================================================================
# Self-Contained Module Configuration
# =========================================================================
is_self_contained=True,
services_path="app.modules.orders.services",
models_path="app.modules.orders.models",
schemas_path="app.modules.orders.schemas",
exceptions_path="app.modules.orders.exceptions",
)
def get_orders_module_with_routers() -> ModuleDefinition:
"""
Get orders module with routers attached.
This function attaches the routers lazily to avoid circular imports
during module initialization.
"""
orders_module.admin_router = _get_admin_router()
orders_module.vendor_router = _get_vendor_router()
return orders_module
__all__ = ["orders_module", "get_orders_module_with_routers"]