Samir Boulahtit
aaff799b5e
Remove db.expunge() calls that were causing DetachedInstanceError when accessing lazy-loaded relationships in tests. Changes: - conftest.py: Add documentation about fixture best practices - auth_fixtures: Remove expunge, keep objects attached to session - customer_fixtures: Remove expunge, add proper relationship loading - vendor_fixtures: Remove expunge, add test_company and other_company fixtures for proper company-vendor relationship setup - marketplace_import_job_fixtures: Remove expunge calls - marketplace_product_fixtures: Remove expunge calls The db fixture already provides test isolation by dropping/recreating tables after each test, so expunge is unnecessary and harmful. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
146 lines
4.1 KiB
Python
146 lines
4.1 KiB
Python
# tests/fixtures/auth_fixtures.py
|
|
"""
|
|
Authentication-related test fixtures.
|
|
|
|
Note: Fixtures should NOT use db.expunge() as it breaks lazy loading.
|
|
See tests/conftest.py for details on fixture best practices.
|
|
"""
|
|
import uuid
|
|
|
|
import pytest
|
|
|
|
from middleware.auth import AuthManager
|
|
from models.database.user import User
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def auth_manager():
|
|
"""Create auth manager instance (session scope since it's stateless)."""
|
|
return AuthManager()
|
|
|
|
|
|
@pytest.fixture
|
|
def test_user(db, auth_manager):
|
|
"""Create a test user with unique username."""
|
|
unique_id = str(uuid.uuid4())[:8]
|
|
hashed_password = auth_manager.hash_password("testpass123")
|
|
user = User(
|
|
email=f"test_{unique_id}@example.com",
|
|
username=f"testuser_{unique_id}",
|
|
hashed_password=hashed_password,
|
|
role="user",
|
|
is_active=True,
|
|
)
|
|
db.add(user)
|
|
db.commit()
|
|
db.refresh(user)
|
|
return user
|
|
|
|
|
|
@pytest.fixture
|
|
def test_admin(db, auth_manager):
|
|
"""Create a test admin user with unique username."""
|
|
unique_id = str(uuid.uuid4())[:8]
|
|
hashed_password = auth_manager.hash_password("adminpass123")
|
|
admin = User(
|
|
email=f"admin_{unique_id}@example.com",
|
|
username=f"admin_{unique_id}",
|
|
hashed_password=hashed_password,
|
|
role="admin",
|
|
is_active=True,
|
|
)
|
|
db.add(admin)
|
|
db.commit()
|
|
db.refresh(admin)
|
|
return admin
|
|
|
|
|
|
@pytest.fixture
|
|
def another_admin(db, auth_manager):
|
|
"""Create another test admin user for testing admin-to-admin interactions."""
|
|
unique_id = str(uuid.uuid4())[:8]
|
|
hashed_password = auth_manager.hash_password("anotheradminpass123")
|
|
admin = User(
|
|
email=f"another_admin_{unique_id}@example.com",
|
|
username=f"another_admin_{unique_id}",
|
|
hashed_password=hashed_password,
|
|
role="admin",
|
|
is_active=True,
|
|
)
|
|
db.add(admin)
|
|
db.commit()
|
|
db.refresh(admin)
|
|
return admin
|
|
|
|
|
|
@pytest.fixture
|
|
def other_user(db, auth_manager):
|
|
"""Create a different user for testing access controls."""
|
|
unique_id = str(uuid.uuid4())[:8]
|
|
hashed_password = auth_manager.hash_password("otherpass123")
|
|
user = User(
|
|
email=f"other_{unique_id}@example.com",
|
|
username=f"otheruser_{unique_id}",
|
|
hashed_password=hashed_password,
|
|
role="user",
|
|
is_active=True,
|
|
)
|
|
db.add(user)
|
|
db.commit()
|
|
db.refresh(user)
|
|
return user
|
|
|
|
|
|
@pytest.fixture
|
|
def auth_headers(client, test_user):
|
|
"""Get authentication headers for test user"""
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
json={"username": test_user.username, "password": "testpass123"},
|
|
)
|
|
assert response.status_code == 200, f"Login failed: {response.text}"
|
|
token = response.json()["access_token"]
|
|
return {"Authorization": f"Bearer {token}"}
|
|
|
|
|
|
@pytest.fixture
|
|
def admin_headers(client, test_admin):
|
|
"""Get authentication headers for admin user"""
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
json={"username": test_admin.username, "password": "adminpass123"},
|
|
)
|
|
assert response.status_code == 200, f"Admin login failed: {response.text}"
|
|
token = response.json()["access_token"]
|
|
return {"Authorization": f"Bearer {token}"}
|
|
|
|
|
|
@pytest.fixture
|
|
def test_vendor_user(db, auth_manager):
|
|
"""Create a test vendor user with unique username."""
|
|
unique_id = str(uuid.uuid4())[:8]
|
|
hashed_password = auth_manager.hash_password("vendorpass123")
|
|
user = User(
|
|
email=f"vendor_{unique_id}@example.com",
|
|
username=f"vendoruser_{unique_id}",
|
|
hashed_password=hashed_password,
|
|
role="vendor",
|
|
is_active=True,
|
|
)
|
|
db.add(user)
|
|
db.commit()
|
|
db.refresh(user)
|
|
return user
|
|
|
|
|
|
@pytest.fixture
|
|
def vendor_user_headers(client, test_vendor_user):
|
|
"""Get authentication headers for vendor user (uses get_current_vendor_api)"""
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
json={"username": test_vendor_user.username, "password": "vendorpass123"},
|
|
)
|
|
assert response.status_code == 200, f"Vendor login failed: {response.text}"
|
|
token = response.json()["access_token"]
|
|
return {"Authorization": f"Bearer {token}"}
|