Samir Boulahtit
b8a46e1746
Problem: - Ruff removed 'from app.core.database import Base' from models/database/base.py - Import appeared "unused" (F401) but was actually a critical re-export - Caused ImportError: cannot import name 'Base' at runtime - Re-export pattern: import in one file to export from package Solution: 1. Added F401 ignore for models/database/base.py in pyproject.toml 2. Created scripts/verify_critical_imports.py verification script 3. Integrated verification into make check and CI pipeline 4. Updated documentation with explanation New Verification Script: - Checks all critical re-export imports exist - Detects import variations (parentheses, 'as' clauses) - Handles SQLAlchemy declarative_base alternatives - Runs as part of make check automatically Protected Files: - models/database/base.py - Re-exports Base for all models - models/__init__.py - Exports Base for Alembic - models/database/__init__.py - Exports Base from package - All __init__.py files (already protected) Makefile Changes: - make verify-imports - Run import verification - make check - Now includes verify-imports - make ci - Includes verify-imports in pipeline Documentation Updated: - Code quality guide explains re-export protection - Pre-commit workflow includes verification - Examples of why re-exports matter This prevents future issues where linters remove seemingly "unused" imports that are actually critical for application structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
142 lines
4.2 KiB
Python
142 lines
4.2 KiB
Python
# app/api/v1/admin/notifications.py
|
|
"""
|
|
Admin notifications and platform alerts endpoints.
|
|
|
|
Provides endpoints for:
|
|
- Viewing admin notifications
|
|
- Managing platform alerts
|
|
- System health monitoring
|
|
"""
|
|
|
|
import logging
|
|
|
|
from fastapi import APIRouter, Depends, Query
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.api.deps import get_current_admin_api
|
|
from app.core.database import get_db
|
|
from models.database.user import User
|
|
from models.schema.admin import (
|
|
AdminNotificationListResponse,
|
|
PlatformAlertCreate,
|
|
PlatformAlertListResponse,
|
|
PlatformAlertResolve,
|
|
PlatformAlertResponse,
|
|
)
|
|
|
|
router = APIRouter(prefix="/notifications")
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
# ============================================================================
|
|
# ADMIN NOTIFICATIONS
|
|
# ============================================================================
|
|
|
|
|
|
@router.get("", response_model=AdminNotificationListResponse)
|
|
def get_notifications(
|
|
priority: str | None = Query(None, description="Filter by priority"),
|
|
is_read: bool | None = Query(None, description="Filter by read status"),
|
|
skip: int = Query(0, ge=0),
|
|
limit: int = Query(50, ge=1, le=100),
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Get admin notifications with filtering."""
|
|
# TODO: Implement notification service
|
|
return AdminNotificationListResponse(
|
|
notifications=[], total=0, unread_count=0, skip=skip, limit=limit
|
|
)
|
|
|
|
|
|
@router.get("/unread-count")
|
|
def get_unread_count(
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Get count of unread notifications."""
|
|
# TODO: Implement
|
|
return {"unread_count": 0}
|
|
|
|
|
|
@router.put("/{notification_id}/read")
|
|
def mark_as_read(
|
|
notification_id: int,
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Mark notification as read."""
|
|
# TODO: Implement
|
|
return {"message": "Notification marked as read"}
|
|
|
|
|
|
@router.put("/mark-all-read")
|
|
def mark_all_as_read(
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Mark all notifications as read."""
|
|
# TODO: Implement
|
|
return {"message": "All notifications marked as read"}
|
|
|
|
|
|
# ============================================================================
|
|
# PLATFORM ALERTS
|
|
# ============================================================================
|
|
|
|
|
|
@router.get("/alerts", response_model=PlatformAlertListResponse)
|
|
def get_platform_alerts(
|
|
severity: str | None = Query(None, description="Filter by severity"),
|
|
is_resolved: bool | None = Query(None, description="Filter by resolution status"),
|
|
skip: int = Query(0, ge=0),
|
|
limit: int = Query(50, ge=1, le=100),
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Get platform alerts with filtering."""
|
|
# TODO: Implement alert service
|
|
return PlatformAlertListResponse(
|
|
alerts=[], total=0, active_count=0, critical_count=0, skip=skip, limit=limit
|
|
)
|
|
|
|
|
|
@router.post("/alerts", response_model=PlatformAlertResponse)
|
|
def create_platform_alert(
|
|
alert_data: PlatformAlertCreate,
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Create new platform alert (manual)."""
|
|
# TODO: Implement
|
|
logger.info(f"Admin {current_admin.username} created alert: {alert_data.title}")
|
|
return {}
|
|
|
|
|
|
@router.put("/alerts/{alert_id}/resolve")
|
|
def resolve_platform_alert(
|
|
alert_id: int,
|
|
resolve_data: PlatformAlertResolve,
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Resolve platform alert."""
|
|
# TODO: Implement
|
|
logger.info(f"Admin {current_admin.username} resolved alert {alert_id}")
|
|
return {"message": "Alert resolved successfully"}
|
|
|
|
|
|
@router.get("/alerts/stats")
|
|
def get_alert_statistics(
|
|
db: Session = Depends(get_db),
|
|
current_admin: User = Depends(get_current_admin_api),
|
|
):
|
|
"""Get alert statistics for dashboard."""
|
|
# TODO: Implement
|
|
return {
|
|
"total_alerts": 0,
|
|
"active_alerts": 0,
|
|
"critical_alerts": 0,
|
|
"resolved_today": 0,
|
|
}
|