Samir Boulahtit
b8a46e1746
Problem: - Ruff removed 'from app.core.database import Base' from models/database/base.py - Import appeared "unused" (F401) but was actually a critical re-export - Caused ImportError: cannot import name 'Base' at runtime - Re-export pattern: import in one file to export from package Solution: 1. Added F401 ignore for models/database/base.py in pyproject.toml 2. Created scripts/verify_critical_imports.py verification script 3. Integrated verification into make check and CI pipeline 4. Updated documentation with explanation New Verification Script: - Checks all critical re-export imports exist - Detects import variations (parentheses, 'as' clauses) - Handles SQLAlchemy declarative_base alternatives - Runs as part of make check automatically Protected Files: - models/database/base.py - Re-exports Base for all models - models/__init__.py - Exports Base for Alembic - models/database/__init__.py - Exports Base from package - All __init__.py files (already protected) Makefile Changes: - make verify-imports - Run import verification - make check - Now includes verify-imports - make ci - Includes verify-imports in pipeline Documentation Updated: - Code quality guide explains re-export protection - Pre-commit workflow includes verification - Examples of why re-exports matter This prevents future issues where linters remove seemingly "unused" imports that are actually critical for application structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
56 lines
1.6 KiB
Python
56 lines
1.6 KiB
Python
# models/database/cart.py
|
|
"""Cart item database model."""
|
|
|
|
from sqlalchemy import (
|
|
Column,
|
|
Float,
|
|
ForeignKey,
|
|
Index,
|
|
Integer,
|
|
String,
|
|
UniqueConstraint,
|
|
)
|
|
from sqlalchemy.orm import relationship
|
|
|
|
from app.core.database import Base
|
|
from models.database.base import TimestampMixin
|
|
|
|
|
|
class CartItem(Base, TimestampMixin):
|
|
"""
|
|
Shopping cart items.
|
|
|
|
Stores cart items per session, vendor, and product.
|
|
Sessions are identified by a session_id string (from browser cookies).
|
|
"""
|
|
|
|
__tablename__ = "cart_items"
|
|
|
|
id = Column(Integer, primary_key=True, index=True)
|
|
vendor_id = Column(Integer, ForeignKey("vendors.id"), nullable=False)
|
|
product_id = Column(Integer, ForeignKey("products.id"), nullable=False)
|
|
session_id = Column(String(255), nullable=False, index=True)
|
|
|
|
# Cart details
|
|
quantity = Column(Integer, nullable=False, default=1)
|
|
price_at_add = Column(Float, nullable=False) # Store price when added to cart
|
|
|
|
# Relationships
|
|
vendor = relationship("Vendor")
|
|
product = relationship("Product")
|
|
|
|
# Constraints
|
|
__table_args__ = (
|
|
UniqueConstraint("vendor_id", "session_id", "product_id", name="uq_cart_item"),
|
|
Index("idx_cart_session", "vendor_id", "session_id"),
|
|
Index("idx_cart_created", "created_at"), # For cleanup of old carts
|
|
)
|
|
|
|
def __repr__(self):
|
|
return f"<CartItem(id={self.id}, session='{self.session_id}', product_id={self.product_id}, qty={self.quantity})>"
|
|
|
|
@property
|
|
def line_total(self) -> float:
|
|
"""Calculate line total."""
|
|
return self.price_at_add * self.quantity
|