Samir Boulahtit
d99633345f
Adds acting_terminal_device_id to loyalty_transactions so the audit log can distinguish between operations performed via the web terminal (human user JWT) and operations performed via a paired tablet (device JWT). The principal-of-record stays the pairing user — existing reports keep working — and this column adds "which tablet did it" alongside. Threaded through every store-API endpoint that creates a transaction (stamp add/redeem/void, points earn/redeem/void/adjust, enrollment + welcome bonus, card deactivate/reactivate). The route reads current_user.terminal_device_id, which the bearer-auth dep populates when a device JWT is presented. User-token requests leave the column NULL, as covered by the new test. Bulk admin operations (GDPR anonymization, bulk deactivate) and Celery tasks (point expiration) are not threaded — they always come from a human admin or the scheduler, never a tablet. - Migration loyalty_011 + LoyaltyTransaction.acting_terminal_device_id - 9 service signatures gain the optional kwarg - 8 store-API routes pass it through - Integration tests: device JWT populates the column, user JWT leaves it NULL Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
260 lines
8.9 KiB
Python
260 lines
8.9 KiB
Python
# app/modules/loyalty/tests/integration/test_terminal_devices.py
|
|
"""Integration tests for terminal device pairing & revocation.
|
|
|
|
Covers both the merchant API (`/api/v1/merchants/loyalty/devices/...`) and
|
|
the admin-on-behalf API (`/api/v1/admin/loyalty/merchants/{id}/devices/...`),
|
|
plus the bearer-auth path on the store API that accepts a paired-device JWT.
|
|
"""
|
|
|
|
import pytest
|
|
from jose import jwt
|
|
|
|
from app.modules.loyalty.models import TerminalDevice
|
|
from middleware.auth import AuthManager
|
|
|
|
MERCHANT_BASE = "/api/v1/merchants/loyalty"
|
|
STORE_BASE = "/api/v1/store/loyalty"
|
|
|
|
|
|
@pytest.mark.integration
|
|
@pytest.mark.api
|
|
@pytest.mark.loyalty
|
|
class TestMerchantPairing:
|
|
"""POST /merchants/loyalty/devices — creates row and returns one-time QR."""
|
|
|
|
def test_pair_device_returns_setup_token_and_qr(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup, db
|
|
):
|
|
store = loyalty_store_setup["store"]
|
|
response = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": "Counter 1"},
|
|
headers=loyalty_merchant_headers,
|
|
)
|
|
assert response.status_code == 201, response.text
|
|
data = response.json()
|
|
|
|
assert data["label"] == "Counter 1"
|
|
assert data["store_id"] == store.id
|
|
assert data["status"] == "active"
|
|
assert data["setup_token"]
|
|
assert data["qr_png_base64"].startswith("data:image/png;base64,")
|
|
assert data["setup_payload"]["store_code"] == store.store_code
|
|
assert data["setup_payload"]["auth_token"] == data["setup_token"]
|
|
|
|
# Token is signed by AuthManager and carries the device_setup claim
|
|
# plus the same jti as the row.
|
|
auth = AuthManager()
|
|
decoded = jwt.decode(
|
|
data["setup_token"], auth.secret_key, algorithms=[auth.algorithm]
|
|
)
|
|
assert decoded["device_setup"] is True
|
|
assert decoded["store_id"] == store.id
|
|
device = (
|
|
db.query(TerminalDevice)
|
|
.filter(TerminalDevice.id == data["id"])
|
|
.first()
|
|
)
|
|
assert device is not None
|
|
assert device.jti == decoded["jti"]
|
|
|
|
def test_pair_device_rejects_foreign_store(
|
|
self, client, loyalty_merchant_headers, db
|
|
):
|
|
"""A merchant cannot pair against a store they don't own."""
|
|
# store_id=99999 doesn't belong to this merchant
|
|
response = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": 99999, "label": "Hijack"},
|
|
headers=loyalty_merchant_headers,
|
|
)
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.integration
|
|
@pytest.mark.api
|
|
@pytest.mark.loyalty
|
|
class TestMerchantListAndRevoke:
|
|
"""GET / POST revoke — listing and lifecycle."""
|
|
|
|
def test_list_excludes_revoked_by_default(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup
|
|
):
|
|
store = loyalty_store_setup["store"]
|
|
# Pair two devices
|
|
for label in ("A", "B"):
|
|
r = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": label},
|
|
headers=loyalty_merchant_headers,
|
|
)
|
|
assert r.status_code == 201
|
|
# Revoke first one
|
|
listing = client.get(
|
|
f"{MERCHANT_BASE}/devices", headers=loyalty_merchant_headers
|
|
).json()
|
|
first_id = listing["devices"][-1]["id"] # deterministic order: created_at desc
|
|
r = client.post(
|
|
f"{MERCHANT_BASE}/devices/{first_id}/revoke",
|
|
json={"reason": "lost"},
|
|
headers=loyalty_merchant_headers,
|
|
)
|
|
assert r.status_code == 200
|
|
assert r.json()["status"] == "revoked"
|
|
|
|
# Default list excludes the revoked one
|
|
active = client.get(
|
|
f"{MERCHANT_BASE}/devices", headers=loyalty_merchant_headers
|
|
).json()
|
|
assert active["total"] == 1
|
|
|
|
# include_revoked=true brings it back
|
|
full = client.get(
|
|
f"{MERCHANT_BASE}/devices?include_revoked=true",
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
assert full["total"] == 2
|
|
|
|
def test_revoke_is_idempotent(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup
|
|
):
|
|
store = loyalty_store_setup["store"]
|
|
r = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": "Idem"},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
first = client.post(
|
|
f"{MERCHANT_BASE}/devices/{r['id']}/revoke",
|
|
json={},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
second = client.post(
|
|
f"{MERCHANT_BASE}/devices/{r['id']}/revoke",
|
|
json={},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
assert first["revoked_at"] == second["revoked_at"]
|
|
|
|
|
|
@pytest.mark.integration
|
|
@pytest.mark.api
|
|
@pytest.mark.loyalty
|
|
class TestStoreAPIBearerAuth:
|
|
"""Paired-device JWT is accepted on the store API."""
|
|
|
|
def test_device_token_authenticates_store_api(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup
|
|
):
|
|
store = loyalty_store_setup["store"]
|
|
paired = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": "Counter 1"},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
token = paired["setup_token"]
|
|
|
|
response = client.get(
|
|
f"{STORE_BASE}/program",
|
|
headers={"Authorization": f"Bearer {token}"},
|
|
)
|
|
assert response.status_code == 200, response.text
|
|
body = response.json()
|
|
assert body["merchant_id"] == loyalty_store_setup["merchant"].id
|
|
|
|
def test_revoked_device_token_is_rejected(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup
|
|
):
|
|
store = loyalty_store_setup["store"]
|
|
paired = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": "Burn"},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
token = paired["setup_token"]
|
|
|
|
client.post(
|
|
f"{MERCHANT_BASE}/devices/{paired['id']}/revoke",
|
|
json={"reason": "test"},
|
|
headers=loyalty_merchant_headers,
|
|
)
|
|
|
|
response = client.get(
|
|
f"{STORE_BASE}/program",
|
|
headers={"Authorization": f"Bearer {token}"},
|
|
)
|
|
assert response.status_code in (400, 401)
|
|
|
|
|
|
@pytest.mark.integration
|
|
@pytest.mark.api
|
|
@pytest.mark.loyalty
|
|
class TestActingDeviceAudit:
|
|
"""Transactions performed via a device JWT carry acting_terminal_device_id."""
|
|
|
|
def test_points_earn_via_device_stamps_audit_column(
|
|
self, client, loyalty_merchant_headers, loyalty_store_setup, db
|
|
):
|
|
from app.modules.loyalty.models import LoyaltyTransaction
|
|
from app.modules.loyalty.models.loyalty_transaction import TransactionType
|
|
|
|
store = loyalty_store_setup["store"]
|
|
card = loyalty_store_setup["card"]
|
|
|
|
paired = client.post(
|
|
f"{MERCHANT_BASE}/devices",
|
|
json={"store_id": store.id, "label": "Counter 1"},
|
|
headers=loyalty_merchant_headers,
|
|
).json()
|
|
device_id = paired["id"]
|
|
token = paired["setup_token"]
|
|
|
|
response = client.post(
|
|
f"{STORE_BASE}/points/earn",
|
|
json={"card_id": card.id, "purchase_amount_cents": 1500},
|
|
headers={"Authorization": f"Bearer {token}"},
|
|
)
|
|
assert response.status_code == 200, response.text
|
|
|
|
tx = (
|
|
db.query(LoyaltyTransaction)
|
|
.filter(
|
|
LoyaltyTransaction.card_id == card.id,
|
|
LoyaltyTransaction.transaction_type
|
|
== TransactionType.POINTS_EARNED.value,
|
|
)
|
|
.order_by(LoyaltyTransaction.id.desc())
|
|
.first()
|
|
)
|
|
assert tx is not None
|
|
assert tx.acting_terminal_device_id == device_id
|
|
|
|
def test_user_token_leaves_audit_column_null(
|
|
self, client, loyalty_store_headers, loyalty_store_setup, db
|
|
):
|
|
"""Web-terminal user JWT must NOT stamp acting_terminal_device_id."""
|
|
from app.modules.loyalty.models import LoyaltyTransaction
|
|
from app.modules.loyalty.models.loyalty_transaction import TransactionType
|
|
|
|
card = loyalty_store_setup["card"]
|
|
|
|
response = client.post(
|
|
f"{STORE_BASE}/points/earn",
|
|
json={"card_id": card.id, "purchase_amount_cents": 1500},
|
|
headers=loyalty_store_headers,
|
|
)
|
|
assert response.status_code == 200, response.text
|
|
|
|
tx = (
|
|
db.query(LoyaltyTransaction)
|
|
.filter(
|
|
LoyaltyTransaction.card_id == card.id,
|
|
LoyaltyTransaction.transaction_type
|
|
== TransactionType.POINTS_EARNED.value,
|
|
)
|
|
.order_by(LoyaltyTransaction.id.desc())
|
|
.first()
|
|
)
|
|
assert tx is not None
|
|
assert tx.acting_terminal_device_id is None
|