Samir Boulahtit
b8a46e1746
Problem: - Ruff removed 'from app.core.database import Base' from models/database/base.py - Import appeared "unused" (F401) but was actually a critical re-export - Caused ImportError: cannot import name 'Base' at runtime - Re-export pattern: import in one file to export from package Solution: 1. Added F401 ignore for models/database/base.py in pyproject.toml 2. Created scripts/verify_critical_imports.py verification script 3. Integrated verification into make check and CI pipeline 4. Updated documentation with explanation New Verification Script: - Checks all critical re-export imports exist - Detects import variations (parentheses, 'as' clauses) - Handles SQLAlchemy declarative_base alternatives - Runs as part of make check automatically Protected Files: - models/database/base.py - Re-exports Base for all models - models/__init__.py - Exports Base for Alembic - models/database/__init__.py - Exports Base from package - All __init__.py files (already protected) Makefile Changes: - make verify-imports - Run import verification - make check - Now includes verify-imports - make ci - Includes verify-imports in pipeline Documentation Updated: - Code quality guide explains re-export protection - Pre-commit workflow includes verification - Examples of why re-exports matter This prevents future issues where linters remove seemingly "unused" imports that are actually critical for application structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
81 lines
2.7 KiB
Python
81 lines
2.7 KiB
Python
from sqlalchemy import (
|
|
Column,
|
|
Index,
|
|
Integer,
|
|
String,
|
|
)
|
|
from sqlalchemy.orm import relationship
|
|
|
|
# Import Base from the central database module instead of creating a new one
|
|
from app.core.database import Base
|
|
from models.database.base import TimestampMixin
|
|
|
|
|
|
class MarketplaceProduct(Base, TimestampMixin):
|
|
__tablename__ = "marketplace_products"
|
|
|
|
id = Column(Integer, primary_key=True, index=True)
|
|
marketplace_product_id = Column(String, unique=True, index=True, nullable=False)
|
|
title = Column(String, nullable=False)
|
|
description = Column(String)
|
|
link = Column(String)
|
|
image_link = Column(String)
|
|
availability = Column(String, index=True) # Index for filtering
|
|
price = Column(String)
|
|
brand = Column(String, index=True) # Index for filtering
|
|
gtin = Column(String, index=True) # Index for inventory lookups
|
|
mpn = Column(String)
|
|
condition = Column(String)
|
|
adult = Column(String)
|
|
multipack = Column(Integer)
|
|
is_bundle = Column(String)
|
|
age_group = Column(String)
|
|
color = Column(String)
|
|
gender = Column(String)
|
|
material = Column(String)
|
|
pattern = Column(String)
|
|
size = Column(String)
|
|
size_type = Column(String)
|
|
size_system = Column(String)
|
|
item_group_id = Column(String)
|
|
google_product_category = Column(String, index=True) # Index for filtering
|
|
product_type = Column(String)
|
|
custom_label_0 = Column(String)
|
|
custom_label_1 = Column(String)
|
|
custom_label_2 = Column(String)
|
|
custom_label_3 = Column(String)
|
|
custom_label_4 = Column(String)
|
|
additional_image_link = Column(String)
|
|
sale_price = Column(String)
|
|
unit_pricing_measure = Column(String)
|
|
unit_pricing_base_measure = Column(String)
|
|
identifier_exists = Column(String)
|
|
shipping = Column(String)
|
|
currency = Column(String)
|
|
|
|
# New marketplace fields
|
|
marketplace = Column(
|
|
String, index=True, nullable=True, default="Letzshop"
|
|
) # Index for marketplace filtering
|
|
vendor_name = Column(
|
|
String, index=True, nullable=True
|
|
) # Index for vendor filtering
|
|
|
|
product = relationship("Product", back_populates="marketplace_product")
|
|
|
|
# Additional indexes for marketplace queries
|
|
__table_args__ = (
|
|
Index(
|
|
"idx_marketplace_vendor", "marketplace", "vendor_name"
|
|
), # Composite index for marketplace+vendor queries
|
|
Index(
|
|
"idx_marketplace_brand", "marketplace", "brand"
|
|
), # Composite index for marketplace+brand queries
|
|
)
|
|
|
|
def __repr__(self):
|
|
return (
|
|
f"<MarketplaceProduct(marketplace_product_id='{self.marketplace_product_id}', title='{self.title}', marketplace='{self.marketplace}', "
|
|
f"vendor='{self.vendor_name}')>"
|
|
)
|