fix: protect critical re-export imports from linter removal

Problem:
- Ruff removed 'from app.core.database import Base' from models/database/base.py
- Import appeared "unused" (F401) but was actually a critical re-export
- Caused ImportError: cannot import name 'Base' at runtime
- Re-export pattern: import in one file to export from package

Solution:
1. Added F401 ignore for models/database/base.py in pyproject.toml
2. Created scripts/verify_critical_imports.py verification script
3. Integrated verification into make check and CI pipeline
4. Updated documentation with explanation

New Verification Script:
- Checks all critical re-export imports exist
- Detects import variations (parentheses, 'as' clauses)
- Handles SQLAlchemy declarative_base alternatives
- Runs as part of make check automatically

Protected Files:
- models/database/base.py - Re-exports Base for all models
- models/__init__.py - Exports Base for Alembic
- models/database/__init__.py - Exports Base from package
- All __init__.py files (already protected)

Makefile Changes:
- make verify-imports - Run import verification
- make check - Now includes verify-imports
- make ci - Includes verify-imports in pipeline

Documentation Updated:
- Code quality guide explains re-export protection
- Pre-commit workflow includes verification
- Examples of why re-exports matter

This prevents future issues where linters remove seemingly
"unused" imports that are actually critical for application structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

app/api/deps.py

@@ -367,9 +367,7 @@ def get_current_customer_from_cookie_or_header(
 
         # Verify token hasn't expired
         exp = payload.get("exp")
-        if exp and datetime.fromtimestamp(exp, tz=UTC) < datetime.now(
-            UTC
-        ):
+        if exp and datetime.fromtimestamp(exp, tz=UTC) < datetime.now(UTC):
             logger.warning(f"Expired customer token for customer_id={customer_id}")
             raise InvalidTokenException("Token has expired")
 

app/api/v1/admin/content_pages.py

@@ -48,9 +48,7 @@ class ContentPageCreate(BaseModel):
     meta_description: str | None = Field(
         None, max_length=300, description="SEO meta description"
     )
-    meta_keywords: str | None = Field(
-        None, max_length=300, description="SEO keywords"
-    )
+    meta_keywords: str | None = Field(None, max_length=300, description="SEO keywords")
     is_published: bool = Field(default=False, description="Publish immediately")
     show_in_footer: bool = Field(default=True, description="Show in footer navigation")
     show_in_header: bool = Field(default=False, description="Show in header navigation")

app/api/v1/admin/notifications.py

@@ -88,9 +88,7 @@ def mark_all_as_read(
 @router.get("/alerts", response_model=PlatformAlertListResponse)
 def get_platform_alerts(
     severity: str | None = Query(None, description="Filter by severity"),
-    is_resolved: bool | None = Query(
-        None, description="Filter by resolution status"
-    ),
+    is_resolved: bool | None = Query(None, description="Filter by resolution status"),
     skip: int = Query(0, ge=0),
     limit: int = Query(50, ge=1, le=100),
     db: Session = Depends(get_db),

app/api/v1/shop/products.py

@@ -30,9 +30,7 @@ def get_product_catalog(
     skip: int = Query(0, ge=0),
     limit: int = Query(100, ge=1, le=1000),
     search: str | None = Query(None, description="Search products by name"),
-    is_featured: bool | None = Query(
-        None, description="Filter by featured products"
-    ),
+    is_featured: bool | None = Query(None, description="Filter by featured products"),
     db: Session = Depends(get_db),
 ):
     """

app/api/v1/vendor/content_pages.py

@@ -43,9 +43,7 @@ class VendorContentPageCreate(BaseModel):
     meta_description: str | None = Field(
         None, max_length=300, description="SEO meta description"
     )
-    meta_keywords: str | None = Field(
-        None, max_length=300, description="SEO keywords"
-    )
+    meta_keywords: str | None = Field(None, max_length=300, description="SEO keywords")
     is_published: bool = Field(default=False, description="Publish immediately")
     show_in_footer: bool = Field(default=True, description="Show in footer navigation")
     show_in_header: bool = Field(default=False, description="Show in header navigation")