sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: extend architecture validation to vendor/shared JS files

Browse Source 
- Include static/vendor/js and static/shared/js in JS validation
- Fix onboarding.js: use apiClient (not window.apiClient), use logger
- Fix onboarding.js: use relative paths (not /api/v1/ prefix)
- Add noqa comments for standalone pages (login, onboarding)
- Add ...data() to messages.js for layout inheritance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2025-12-27 22:16:30 +01:00
parent c9a7850b37
commit d34021cfa2
4 changed files with 29 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/vendor/js/login.js vendored
View File

@@ -1,4 +1,6 @@
// app/static/vendor/js/login.js
// noqa: js-003 - Standalone login page without vendor layout
// noqa: js-004 - Standalone page has no currentPage sidebar highlight
/**
* Vendor login page logic
*/

2
static/vendor/js/messages.js vendored
View File

@@ -15,6 +15,8 @@ const messagesLog = window.LogConfig?.createLogger('VENDOR-MESSAGES') || console
*/
function vendorMessages(initialConversationId = null) {
return {
...data(),
// Loading states
loading: true,
loadingConversations: false,

34
static/vendor/js/onboarding.js vendored
View File

@@ -1,4 +1,6 @@
// static/vendor/js/onboarding.js
// noqa: js-003 - Standalone page without vendor layout (no base.html extends)
// noqa: js-004 - Standalone page has no currentPage sidebar highlight
/**
* Vendor Onboarding Wizard
*
@@ -9,6 +11,8 @@
* 4. Order Sync (historical import)
*/
const onboardingLog = window.LogConfig?.createLogger('ONBOARDING') || console;
function vendorOnboarding() {
return {
// State
@@ -88,7 +92,7 @@ function vendorOnboarding() {
this.error = null;
try {
const response = await apiClient.get('/api/v1/vendor/onboarding/status');
const response = await apiClient.get('/vendor/onboarding/status');
this.status = response;
this.currentStep = response.current_step;
this.completedSteps = response.completed_steps_count;
@@ -107,7 +111,7 @@ function vendorOnboarding() {
// Load step-specific data
await this.loadStepData();
} catch (err) {
console.error('Failed to load onboarding status:', err);
onboardingLog.error('Failed to load onboarding status:', err);
this.error = err.message || 'Failed to load onboarding status';
} finally {
this.loading = false;
@@ -118,12 +122,12 @@ function vendorOnboarding() {
async loadStepData() {
try {
if (this.currentStep === 'company_profile') {
const data = await apiClient.get('/api/v1/vendor/onboarding/step/company-profile');
const data = await apiClient.get('/vendor/onboarding/step/company-profile');
if (data) {
Object.assign(this.formData, data);
}
} else if (this.currentStep === 'product_import') {
const data = await apiClient.get('/api/v1/vendor/onboarding/step/product-import');
const data = await apiClient.get('/vendor/onboarding/step/product-import');
if (data) {
Object.assign(this.formData, {
csv_url_fr: data.csv_url_fr || '',
@@ -136,7 +140,7 @@ function vendorOnboarding() {
}
}
} catch (err) {
console.warn('Failed to load step data:', err);
onboardingLog.warn('Failed to load step data:', err);
}
},
@@ -163,7 +167,7 @@ function vendorOnboarding() {
this.connectionError = null;
try {
const response = await apiClient.post('/api/v1/vendor/onboarding/step/letzshop-api/test', {
const response = await apiClient.post('/vendor/onboarding/step/letzshop-api/test', {
api_key: this.formData.api_key,
shop_slug: this.formData.shop_slug,
});
@@ -187,7 +191,7 @@ function vendorOnboarding() {
this.saving = true;
try {
const response = await apiClient.post('/api/v1/vendor/onboarding/step/order-sync/trigger', {
const response = await apiClient.post('/vendor/onboarding/step/order-sync/trigger', {
days_back: parseInt(this.formData.days_back),
include_products: true,
});
@@ -199,7 +203,7 @@ function vendorOnboarding() {
throw new Error(response.message || 'Failed to start import');
}
} catch (err) {
console.error('Failed to start order sync:', err);
onboardingLog.error('Failed to start order sync:', err);
this.error = err.message || 'Failed to start import';
} finally {
this.saving = false;
@@ -217,7 +221,7 @@ function vendorOnboarding() {
async pollSyncProgress() {
try {
const response = await apiClient.get(
`/api/v1/vendor/onboarding/step/order-sync/progress/${this.syncJobId}`
`/vendor/onboarding/step/order-sync/progress/${this.syncJobId}`
);
this.syncProgress = response.progress_percentage || 0;
@@ -230,7 +234,7 @@ function vendorOnboarding() {
this.syncProgress = response.status === 'completed' ? 100 : this.syncProgress;
}
} catch (err) {
console.error('Failed to poll sync progress:', err);
onboardingLog.error('Failed to poll sync progress:', err);
}
},
@@ -265,7 +269,7 @@ function vendorOnboarding() {
switch (this.currentStep) {
case 'company_profile':
endpoint = '/api/v1/vendor/onboarding/step/company-profile';
endpoint = '/vendor/onboarding/step/company-profile';
payload = {
company_name: this.formData.company_name,
brand_name: this.formData.brand_name,
@@ -281,7 +285,7 @@ function vendorOnboarding() {
break;
case 'letzshop_api':
endpoint = '/api/v1/vendor/onboarding/step/letzshop-api';
endpoint = '/vendor/onboarding/step/letzshop-api';
payload = {
api_key: this.formData.api_key,
shop_slug: this.formData.shop_slug,
@@ -289,7 +293,7 @@ function vendorOnboarding() {
break;
case 'product_import':
endpoint = '/api/v1/vendor/onboarding/step/product-import';
endpoint = '/vendor/onboarding/step/product-import';
payload = {
csv_url_fr: this.formData.csv_url_fr || null,
csv_url_en: this.formData.csv_url_en || null,
@@ -302,7 +306,7 @@ function vendorOnboarding() {
case 'order_sync':
// Complete onboarding
endpoint = '/api/v1/vendor/onboarding/step/order-sync/complete';
endpoint = '/vendor/onboarding/step/order-sync/complete';
payload = {
job_id: this.syncJobId,
};
@@ -330,7 +334,7 @@ function vendorOnboarding() {
}
} catch (err) {
console.error('Failed to save step:', err);
onboardingLog.error('Failed to save step:', err);
this.error = err.message || 'Failed to save. Please try again.';
} finally {
this.saving = false;