fix: add noqa comments for email service db.commit() calls

Email logs are side effects that need immediate persistence,
so db.commit() is intentional in these cases.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-27 22:08:40 +01:00
parent 55097f5933
commit c9a7850b37

View File

@@ -437,7 +437,7 @@ class EmailService:
related_id=related_id,
)
self.db.add(log)
self.db.commit()
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
return log
# Render template
@@ -519,7 +519,7 @@ class EmailService:
if not settings.email_enabled:
log.status = EmailStatus.FAILED.value
log.error_message = "Email sending is disabled"
self.db.commit()
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
logger.info(f"Email sending disabled, skipping: {to_email}")
return log
@@ -542,7 +542,7 @@ class EmailService:
log.mark_failed(error or "Unknown error")
logger.error(f"Email failed to {to_email}: {error}")
self.db.commit()
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
return log