fix(i18n): locale-aware date/number formatting in loyalty factories
Some checks failed
CI / ruff (push) Successful in 17s
CI / validate (push) Has been cancelled
CI / dependency-scanning (push) Has been cancelled
CI / docs (push) Has been cancelled
CI / deploy (push) Has been cancelled
CI / pytest (push) Has started running

Dates rendered in English even when the dashboard language was set to
French (or any other locale). The 5 shared loyalty Alpine factories
hardcoded 'en-US' in every toLocaleDateString / toLocaleString /
Intl.NumberFormat call, ignoring the user's selected language.

- Add `I18n.locale` getter to static/shared/js/i18n.js that returns
  the current dashboard language code (en/fr/de/lb). Falls back to
  'en' if I18n isn't initialised yet.
- Replace 'en-US' with I18n.locale in 5 loyalty shared factories:
  loyalty-cards-list, loyalty-card-detail-view, loyalty-transactions-
  list, loyalty-pins-list, loyalty-devices-list.
- Also fix a latent bug in loyalty-transactions-list.formatDateTime
  that called toLocaleDateString with hour/minute opts (silently
  ignored — same bug previously fixed in loyalty-card-detail-view).

Scoped to loyalty per session decision; other modules with the same
hardcoded 'en-US' pattern (catalog, billing, etc.) are tracked as a
follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-24 23:03:03 +02:00
parent d32c1fd545
commit dd1f9af811
6 changed files with 21 additions and 11 deletions

View File

@@ -177,13 +177,13 @@ function loyaltyCardDetailView(config) {
// Formatting helpers
formatNumber(num) {
return num == null ? '0' : new Intl.NumberFormat('en-US').format(num);
return num == null ? '0' : new Intl.NumberFormat(I18n.locale).format(num);
},
formatDate(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'
@@ -196,7 +196,7 @@ function loyaltyCardDetailView(config) {
formatDateTime(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleString('en-US', {
return new Date(dateString).toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

View File

@@ -223,13 +223,13 @@ function loyaltyCardsList(config) {
// Formatting helpers
formatNumber(num) {
return num == null ? '0' : new Intl.NumberFormat('en-US').format(num);
return num == null ? '0' : new Intl.NumberFormat(I18n.locale).format(num);
},
formatDate(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'

View File

@@ -110,7 +110,7 @@ function loyaltyDevicesList(config) {
formatDate(value) {
if (!value) return '-';
try {
return new Date(value).toLocaleString();
return new Date(value).toLocaleString(I18n.locale);
} catch (e) {
return value;
}

View File

@@ -317,7 +317,7 @@ function loyaltyPinsList(config) {
formatDate(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'
@@ -330,7 +330,7 @@ function loyaltyPinsList(config) {
formatDateTime(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

View File

@@ -209,13 +209,13 @@ function loyaltyTransactionsList(config) {
// Formatting helpers
formatNumber(num) {
return num == null ? '0' : new Intl.NumberFormat('en-US').format(num);
return num == null ? '0' : new Intl.NumberFormat(I18n.locale).format(num);
},
formatDate(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'
@@ -228,7 +228,7 @@ function loyaltyTransactionsList(config) {
formatDateTime(dateString) {
if (!dateString) return 'Never';
try {
return new Date(dateString).toLocaleDateString('en-US', {
return new Date(dateString).toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

View File

@@ -170,6 +170,16 @@ const I18n = {
}
},
/**
* BCP-47 locale tag for the current dashboard language.
* Use as the first arg to Intl.* / toLocale* APIs so dates and numbers
* render in the user's language instead of the browser default.
* Falls back to 'en' (which is what the dashboards default to).
*/
get locale() {
return this._language || 'en';
},
/**
* Notify Alpine (and other listeners) that translations are ready.
* Bumps the Alpine store version so reactive $t() bindings re-evaluate.